-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/5657 #5658
base: v1.x
Are you sure you want to change the base?
fix/5657 #5658
Conversation
919bac2
to
26ecce6
Compare
I like this fix, but its probably worth noting that this is a breaking change 🤔 |
Well noted. How can I add notes for this breaking change? |
Assuming semantic commits https://www.conventionalcommits.org/en/v1.0.0, you need to either trail your commit with eg:
or:
|
please use |
when is this fix coming in to release? |
f64897d
to
1d5304c
Compare
1d5304c
to
21a5ad3
Compare
cd188ae
to
a330f6d
Compare
Why isn`t it merged yet? =( |
82b18ac
to
a067260
Compare
will attend to this soon but do need to be certain about this as it is a breaking change and there will more than likely be a number of people that will not be happy with said change... i may add a option in the config to allow this behaviour |
@jasonsaayman wait it breathless |
@jasonsaayman so? |
@jasonsaayman what will the configuration be like? |
Fixes #5657
Changed for interceptors.request and interceptors.response to be executed in the same order