Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/5657 #5658

Open
wants to merge 3 commits into
base: v1.x
Choose a base branch
from
Open

fix/5657 #5658

wants to merge 3 commits into from

Conversation

WillianAgostini
Copy link
Contributor

Fixes #5657

Changed for interceptors.request and interceptors.response to be executed in the same order

@scagood
Copy link

scagood commented May 19, 2023

I like this fix, but its probably worth noting that this is a breaking change 🤔

@WillianAgostini
Copy link
Contributor Author

I like this fix, but its probably worth noting that this is a breaking change 🤔

Well noted. How can I add notes for this breaking change?
@scagood

@scagood
Copy link

scagood commented May 23, 2023

Assuming semantic commits https://www.conventionalcommits.org/en/v1.0.0, you need to either trail your commit with BREAKING CHANGE, or add an ! to the commit type.

eg:

fix!: change order to push in pushRequestInterceptors

or:

fix: change order to push in pushRequestInterceptors

BREAKING CHANGE: Reverses the order of the request interceptor execution

@jasonsaayman
Copy link
Member

Assuming semantic commits https://www.conventionalcommits.org/en/v1.0.0, you need to either trail your commit with BREAKING CHANGE, or add an ! to the commit type.

eg:

fix!: change order to push in pushRequestInterceptors

or:

fix: change order to push in pushRequestInterceptors

BREAKING CHANGE: Reverses the order of the request interceptor execution

please use fix!: thanks

@xrado
Copy link

xrado commented Jul 7, 2023

when is this fix coming in to release?

@mtnt
Copy link

mtnt commented Sep 8, 2023

Why isn`t it merged yet? =(

@jasonsaayman
Copy link
Member

will attend to this soon but do need to be certain about this as it is a breaking change and there will more than likely be a number of people that will not be happy with said change... i may add a option in the config to allow this behaviour

@mtnt
Copy link

mtnt commented Sep 20, 2023

@jasonsaayman wait it breathless

@mtnt
Copy link

mtnt commented Oct 18, 2023

@jasonsaayman so?

@WillianAgostini
Copy link
Contributor Author

@jasonsaayman what will the configuration be like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request interceptors are called in revers order
5 participants