Adding interpretation of no_proxy #565

inthemill · 2016-12-01T21:35:53Z

As suggested by #434 the interpretation of no_proxy is implemented here.

I would be happy if axios supports no_proxy, as i would be able to use it in my company.

as suggested by #434

coveralls · 2016-12-01T21:39:01Z

Coverage increased (+0.3%) to 93.909% when pulling ed47ef8 on inthemill:master into cfe33d4 on mzabriskie:master.

geekflyer · 2017-03-08T05:03:57Z

can we please merge this soon? Spend hours to figure out why our integration tests were not running in CI environment and it turns out this is due to axios' lack of interpreting no_proxy.

gustarus · 2017-04-07T15:39:17Z

Guys, hello! Is there any movements? We need this feature 🔥.

lgordey · 2017-04-12T08:22:47Z

@mzabriskie @nickuraltsev @rubennorte Hi guys!

We are waiting for this improvement 4 months.
Can we merge this or find out the comments?

Otherwise we will be forced to refuse to use your package, although we really like it 😢

geekflyer · 2017-05-04T06:46:27Z

hey guys, I just couldn't wait anymore, so I republished this branch on npm under axios-no-proxy https://www.npmjs.com/package/axios-no-proxy

jphilipstevens · 2017-05-08T15:45:09Z

We are running into issues because of this. Please bring this in ASAP

hickford · 2017-07-20T08:24:52Z

lib/adapters/http.js

@@ -99,6 +116,9 @@ module.exports = function httpAdapter(config) {
            password: proxyUrlAuth[1]
          };
        }
+        if (isANoProxyHost(proxy.host)) {


Should that be parsed.hostname?

of course. I'll fix that, and check, why the tests don't fail.

as suggested by #434

coveralls · 2017-07-20T21:08:54Z

Coverage increased (+0.08%) to 93.734% when pulling 24ecb51 on inthemill:master into cfe33d4 on mzabriskie:master.

coveralls · 2017-07-20T21:16:01Z

Coverage remained the same at 93.734% when pulling bdcad15 on inthemill:master into f1fb3de on mzabriskie:master.

nareshbhatia · 2017-08-05T23:57:04Z

Any reason why this PR has not been merged since last 8 months? I have spent over 2 weeks tracking down a proxy issue, which could have been solved in 2 minutes if this had been merged. @mzabriskie and other committers, could you please help by accepting this PR?

Thanks in advance.

nareshbhatia · 2017-08-08T20:16:13Z

@mzabriskie, any chance you will be able to accept this PR? My project is blocked because of this. Please just drop a quick response so that we can plan accordingly.

Thanks in advance.

rubennorte · 2017-08-12T12:32:59Z

Sorry for the unreasonable delay.

This NO_PROXY implementation is a good starting point but doesn't implement some usual use cases (like wildcards). I've discovered the proxy-from-env package that handles that (getting the proxy URL for a specific URL using the configuration in the environment), so you may want to use it instead.

WDYT?

rubennorte · 2017-08-12T12:34:33Z

lib/adapters/http.js

@@ -224,3 +244,6 @@ module.exports = function httpAdapter(config) {
    }
  });
 };
+
+
+module.exports._isANoProxyHost = isANoProxyHost;


Please don't export functions just for testing. This can be tested throught the behaviour of the request.

nareshbhatia · 2017-08-12T17:27:34Z

@rubennorte, proxy-from-env looks good but if we use that, it will interfere with Axios. Since Axios already supports HTTP_PROXY and HTTPS_PROXYit will take the URL provided by proxy-from-env and apply the proxy to it anyway. I would prefer to simply add NO_PROXY support to Axios and not have to worry about one more dependency. Of course, the NO_PROXY support would have to implement wildcards also.

rubennorte · 2017-08-12T20:41:04Z

I was suggesting that you could use it because we're most likely to do it anywhere in a following PR, so it could save you some work in the implementation of the wildcards. This only works in Node.js so adding a new dependency here wouldn't be an issue.

nareshbhatia · 2017-08-13T04:52:33Z

Ah, ok @rubennorte. So I assume that your message to use proxy-from-env was addressed to @inthemill - the submitter of the PR.

rubennorte · 2017-08-14T11:35:06Z

@nareshbhatia yep, sorry.

rubennorte · 2017-08-14T11:40:54Z

I just merged #691, which is related to this one.

inthemill · 2017-08-18T19:12:59Z

@rubennorte When I use proxy-from-env it would make sense to change the whole part where the proxy is read from env-variables. This will have a much deeper impact on existing code. Seeing that it is only covered by integration tests, i'm not very confident doing this. I could try, but i would need some help testing all edge cases. Do you want me to do that?

rubennorte · 2017-08-20T18:20:06Z

@inthemill that'd be great. I can give you some support if you need help with anything.

# Conflicts: # lib/adapters/http.js

coveralls · 2017-08-20T21:59:36Z

Coverage remained the same at 93.812% when pulling 44967bf on inthemill:master into 07a7b7c on mzabriskie:master.

inthemill · 2017-08-28T19:52:17Z

@rubennorte what about these changes?

williangd · 2017-10-19T16:18:48Z

Any update about no_proxy?

inthemill · 2017-10-19T18:56:15Z

Yes please. @rubennorte let's merge this PR, it's old enough.

ian-harshman-ck · 2017-10-30T21:05:07Z

@nickuraltsev @rubennorte Please, let's get this merged! We love axios and are looking to support axios connections for a Thrift client library, but we need no_proxy support to use it anywhere beyond dev environments.

gigachel · 2017-11-23T14:59:12Z

Any news about no_proxy?

JulienBourgain · 2018-01-08T15:15:58Z

It's not a good idea to wait 1year before merging an important PR without good reasons...

jphilipstevens · 2018-01-09T03:04:13Z

@nickuraltsev @rubennorte
Can you provide any update?

dejayc · 2018-02-22T15:29:56Z

This is so typical of the Node ecosystem, lol. Becoming dependent upon abandonware.

daggerjames · 2018-06-08T16:43:28Z

seems like we should wait for next year lol

alexbonhomme · 2018-08-30T08:28:59Z

Hey guys !
You should close this PR in favor of #1693 who's merged into master and fix the problem 🎉
This this confusing to keep this open.

Please give a try to https://github.com/axios/axios/tree/v0.19.0-beta.1

Adding interpretation of no_proxy

ed47ef8

as suggested by #434

vilinski mentioned this pull request Feb 6, 2017

Is there a way to force not to use proxy? #635

Closed

vbfox mentioned this pull request Feb 7, 2017

Adding a way to disable all proxy processing #691

Merged

hickford reviewed Jul 20, 2017

View reviewed changes

inthemill added 2 commits July 20, 2017 23:05

Fixing interpretation of no_proxy by checking correct hostname

24ecb51

as suggested by #434

Merge remote-tracking branch 'upstream/master'

bdcad15

hickford mentioned this pull request Aug 1, 2017

Can't connect to FSAC if HTTP_PROXY is defined. ionide/ionide-vscode-fsharp#272

Closed

nareshbhatia mentioned this pull request Aug 5, 2017

Axios gives a 504 error on a Windows VM #1021

Closed

rubennorte reviewed Aug 12, 2017

View reviewed changes

inthemill added 3 commits August 20, 2017 23:46

rewrite reading proxy from env using proxy-from-env

afbb7b0

Merge remote-tracking branch 'upstream/master'

94b8c55

# Conflicts: # lib/adapters/http.js

Adding a way to disable all proxy processing (#691) again

44967bf

Merge branch 'master' into master

b0929c7

Merge branch 'master' into master

849cd15

emilyemorehouse force-pushed the master branch 2 times, most recently from 2760755 to 48a7902 Compare February 19, 2018 23:22

pheebcodes mentioned this pull request Jul 24, 2018

Adding support for no_proxy env variable #1693

Merged

inthemill closed this Aug 30, 2018

axios locked and limited conversation to collaborators May 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding interpretation of no_proxy #565

Adding interpretation of no_proxy #565

inthemill commented Dec 1, 2016

coveralls commented Dec 1, 2016

geekflyer commented Mar 8, 2017

gustarus commented Apr 7, 2017 •

edited

lgordey commented Apr 12, 2017

geekflyer commented May 4, 2017

jphilipstevens commented May 8, 2017

hickford Jul 20, 2017

inthemill Jul 20, 2017

coveralls commented Jul 20, 2017

coveralls commented Jul 20, 2017

nareshbhatia commented Aug 5, 2017

nareshbhatia commented Aug 8, 2017

rubennorte commented Aug 12, 2017 •

edited

rubennorte Aug 12, 2017

nareshbhatia commented Aug 12, 2017

rubennorte commented Aug 12, 2017

nareshbhatia commented Aug 13, 2017

rubennorte commented Aug 14, 2017

rubennorte commented Aug 14, 2017

inthemill commented Aug 18, 2017

rubennorte commented Aug 20, 2017

coveralls commented Aug 20, 2017

inthemill commented Aug 28, 2017

williangd commented Oct 19, 2017

inthemill commented Oct 19, 2017

ian-harshman-ck commented Oct 30, 2017

gigachel commented Nov 23, 2017

JulienBourgain commented Jan 8, 2018

jphilipstevens commented Jan 9, 2018

dejayc commented Feb 22, 2018

daggerjames commented Jun 8, 2018

alexbonhomme commented Aug 30, 2018

Adding interpretation of no_proxy #565

Adding interpretation of no_proxy #565

Conversation

inthemill commented Dec 1, 2016

coveralls commented Dec 1, 2016

geekflyer commented Mar 8, 2017

gustarus commented Apr 7, 2017 • edited

lgordey commented Apr 12, 2017

geekflyer commented May 4, 2017

jphilipstevens commented May 8, 2017

hickford Jul 20, 2017

Choose a reason for hiding this comment

inthemill Jul 20, 2017

Choose a reason for hiding this comment

coveralls commented Jul 20, 2017

coveralls commented Jul 20, 2017

nareshbhatia commented Aug 5, 2017

nareshbhatia commented Aug 8, 2017

rubennorte commented Aug 12, 2017 • edited

rubennorte Aug 12, 2017

Choose a reason for hiding this comment

nareshbhatia commented Aug 12, 2017

rubennorte commented Aug 12, 2017

nareshbhatia commented Aug 13, 2017

rubennorte commented Aug 14, 2017

rubennorte commented Aug 14, 2017

inthemill commented Aug 18, 2017

rubennorte commented Aug 20, 2017

coveralls commented Aug 20, 2017

inthemill commented Aug 28, 2017

williangd commented Oct 19, 2017

inthemill commented Oct 19, 2017

ian-harshman-ck commented Oct 30, 2017

gigachel commented Nov 23, 2017

JulienBourgain commented Jan 8, 2018

jphilipstevens commented Jan 9, 2018

dejayc commented Feb 22, 2018

daggerjames commented Jun 8, 2018

alexbonhomme commented Aug 30, 2018

gustarus commented Apr 7, 2017 •

edited

rubennorte commented Aug 12, 2017 •

edited