Fixed AxiosError.toJSON method to avoid circular references;

[DigitalBrainJS]

• Added toJSONObject util;
• Fixed AxiosError.toJSON method to avoid circular references;
  Closes Error.toJSON() should exclude httpsAgent #4486;

[jasonsaayman]

Awesome thanks 🚀

[DamianRivas]

@DigitalBrainJS I noticed you are the original implementer of the toJSON method. I've been wondering, why does this method returns an object instead of a string?

toJSONObject's return type is semantically correct as in the return type is what anyone would expect based on the method name, but I was surprised to learn toJSON's return type isn't stringified.

[DigitalBrainJS]

is what anyone would expect based on the method name

@DamianRivas In fact, no one should expect this, since this is typical behavior for the toJSON method in the context of the JS ecosystem. This method is used to convert an object/model to a JSON object, it does not take care of the final conversion to a JSON string. JSON.stringify should be used for this, which calls it internally.

https://stackoverflow.com/questions/20734894/difference-between-tojson-and-json-stringify

[DamianRivas]

@DigitalBrainJS I had no idea that was a widely used convention. Thank you for clarifying 🙂