Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix problem with named export axios #5104

Closed
wants to merge 2 commits into from
Closed

fix problem with named export axios #5104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81d326e
fix problem with package.json exports declaration for CommonJS
akphi Oct 14, 2022
9ee4b76
update named export in typings
akphi Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Expand Up @@ -480,4 +480,5 @@ export interface AxiosStatic extends AxiosInstance {

declare const axios: AxiosStatic;

export { axios };
export default axios;
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Expand Up @@ -28,5 +28,6 @@ export {
Cancel,
isAxiosError,
spread,
toFormData
toFormData,
axios
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this should not be necessary you can already do this:

import { axios } from 'axios';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my updated PR description. You can check out my repro at akphi/issue-repo#12
There are 2 problems:

  1. For ESM import, I don't think import { axios } from 'axios'; work
  2. For TS, we need to update the typings to have the named export - I just updated the PR with this change

}