New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving proxy from env on redirect #4436
Merged
jasonsaayman
merged 12 commits into
axios:master
from
mbargiel:feature/fix-proxy/resolve-from-env-on-redirect
May 11, 2022
Merged
Resolving proxy from env on redirect #4436
jasonsaayman
merged 12 commits into
axios:master
from
mbargiel:feature/fix-proxy/resolve-from-env-on-redirect
May 11, 2022
+97
−78
Commits on Jan 31, 2022
-
Fixing http adapter to recompute proxy on redirect
Redirections can target different hosts or change the protocol from http to https or vice versa. When the proxy option is inferred from the environment, it should be recomputed when the protocol or host changes because the proxy host can differ or even whether to proxy or not can differ.
Configuration menu - View commit details
-
Copy full SHA for a48dcfb - Browse repository at this point
Copy the full SHA a48dcfbView commit details -
Fixing proxy protocol handling
1) setProxy now changes request options protocol when using a proxy with explicit protocol. 2) As a result, selection of the correct transport can be simplified. 3) Legacy agent selection needs to be moved done accordingly. (Is 'agent' option even still used?)
Configuration menu - View commit details
-
Copy full SHA for 7a86b8b - Browse repository at this point
Copy the full SHA 7a86b8bView commit details -
Using proxy-from-env library to handle proxy env vars
The proxy-from-env library is a popular, lightweight library that is very easy to use and covers a few more cases, not to mention it has extensive test coverage.
Configuration menu - View commit details
-
Copy full SHA for 7a00a50 - Browse repository at this point
Copy the full SHA 7a00a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 706fe5b - Browse repository at this point
Copy the full SHA 706fe5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cf13cb - Browse repository at this point
Copy the full SHA 0cf13cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8d0b5 - Browse repository at this point
Copy the full SHA 2a8d0b5View commit details
Commits on Feb 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a00e179 - Browse repository at this point
Copy the full SHA a00e179View commit details
Commits on May 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9dcdc6e - Browse repository at this point
Copy the full SHA 9dcdc6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57befc3 - Browse repository at this point
Copy the full SHA 57befc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2de3cab - Browse repository at this point
Copy the full SHA 2de3cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for d44952c - Browse repository at this point
Copy the full SHA d44952cView commit details -
Revert "Fixing proxy beforeRedirect regression"
This reverts commit 57befc3.
Configuration menu - View commit details
-
Copy full SHA for 29976b9 - Browse repository at this point
Copy the full SHA 29976b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.