revert: change type of AxiosResponse to any #4186
Merged
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah you’re right I forgot to mention that one, just mentioned the initial PR that brought this issue up. Thanks for the heads up! |
remcohaszing
suggested changes
Oct 13, 2021
My bad xD
macotouenaca
approved these changes
Oct 16, 2021
|
@ImRodry please can you have a look at the failing tests? |
|
@jasonsaayman apologies for the failing tests, they should be good now! |
|
I wasn't able to test this locally because for some reason it relies on Firefox being installed which it's not on my computer so please approve the workflows again to see if more errors arise |
|
Hey @jasonsaayman, thanks for merging the PR! Can we get an ETA on when v0.24 will be released? |
|
Will try and get it out tonight |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* revert: change type of AxiosResponse to any * types: add back default types My bad xD * Remove redundant default params
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #4141 by reverting the change implemented in #3002 (changed the type of AxiosResponse to any).