Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TransitionalOptions typings #4147

Merged
merged 3 commits into from Oct 12, 2021
Merged

Fixed TransitionalOptions typings #4147

merged 3 commits into from Oct 12, 2021

Conversation

DigitalBrainJS
Copy link
Collaborator

@DigitalBrainJS DigitalBrainJS commented Oct 6, 2021 •
edited by jasonsaayman

Just fixed the type definition for the TransitionalOptions interface to mark its properties as optional.

Adding: Refs #3688

@jasonsaayman jasonsaayman changed the base branch from release/v0.22.0 to master October 6, 2021 18:05
@caugner
Copy link
Contributor

caugner commented Oct 6, 2021

Could you please interactively rebase on master and remove the other commits that came as a side-effect of the changed base branch?

Alternatively, you could reset --hard your branch to master and cherry-pick your commit (44f3b9f).

@DigitalBrainJS DigitalBrainJS force-pushed the fix/transitional-options-typings branch from 44f3b9f to 023ee8f Compare October 6, 2021 20:11
@DigitalBrainJS DigitalBrainJS force-pushed the fix/transitional-options-typings branch from 023ee8f to e5f5800 Compare October 6, 2021 20:38
caugner
caugner reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you explain shortly why these properties are optional, e.g. referencing the corresponding code locations or giving an example?

@remcohaszing remcohaszing mentioned this pull request Oct 7, 2021
Merged
@DigitalBrainJS
Copy link
Collaborator Author

DigitalBrainJS commented Oct 7, 2021 •
edited

@caugner That was my PR(#3688) so they are definitely optional, but recently noticed that for some reason I forgot to reflect this in d.ts

@caugner
Copy link
Contributor

caugner commented Oct 7, 2021

@caugner That was my PR(#3688) so they are definitely optional, but recently noticed that for some reason I forgot to reflect this in d.ts

Thanks for the clarification. I would suggest adding Refs #3688 to the PR description to add context to the commit.

@jasonsaayman jasonsaayman merged commit fce210a into axios:master Oct 12, 2021
@redpeacock78 redpeacock78 mentioned this pull request Oct 13, 2021
Merged
@hzaun hzaun mentioned this pull request Dec 9, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 6, 2022
Closed
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
@DigitalBrainJS @jasonsaayman
Fixed TransitionalOptions typings (axios#4147)
b44800e 
Co-authored-by: Jay <jasonsaayman@gmail.com>
This was referenced Feb 22, 2022
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2022
Closed
@rithviknishad rithviknishad mentioned this pull request Jul 4, 2022
Merged
@shaneomatz shaneomatz mentioned this pull request Nov 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner left review comments

@remcohaszing remcohaszing remcohaszing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DigitalBrainJS @caugner @remcohaszing @jasonsaayman