Fixes umd build for non-web targets #4050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
axios@0.21.2
- it fails to run in a NativeScript app. We can work around the issue by aliasing/definingwindow
, but perhaps this affects more projects than just NativeScript.In #3401 webpack has been updated to 4.x, which slightly modified the
axios/dist/axios
umd build:After some searching, I found this issue in the webpack repo: webpack/webpack#6522 that describes the same scenario, and the proposed solution is to add
globalObject: 'this'
to preserve the old behavior.With this fix, running
npm run build
correctly usesthis
as it used to.