fix: response interceptors doesn't work #3952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -5,12 +5,13 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "grunt test", | |||
| "start": "node ./sandbox/server.js", | |||
| "start": "nodemon ./sandbox/server.js", | |||
There was a problem hiding this comment.
Why there are non-related script changes here?
There was a problem hiding this comment.
sorry, I pushed some useless code, I will handle it.
package.json
Outdated
| "preversion": "npm test", | ||
| "version": "npm run build && grunt version && git add -A dist && git add CHANGELOG.md bower.json package.json", | ||
| "postversion": "git push && git push --tags", | ||
| "examples": "node ./examples/server.js", | ||
| "examples": "nodemon ./examples/server.js", |
package.json
Outdated
| @@ -73,7 +74,8 @@ | |||
| "unpkg": "dist/axios.min.js", | |||
| "typings": "./index.d.ts", | |||
| "dependencies": { | |||
| "follow-redirects": "^1.14.0" | |||
| "follow-redirects": "^1.14.0", | |||
| "nodemon": "^2.0.12" | |||
There was a problem hiding this comment.
Do we need this package to support the fix?
There was a problem hiding this comment.
no, we don't need it, I have deleted it.
|
Looks good. If you can add some tests, that will be great. |
|
@chinesedfan Thanks for your advice, (^o^)/~ |
|
Close in favor of #4013 with tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain doesn't include the response interceptors