Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove charset in tests #3807

Merged
merged 6 commits into from May 21, 2021
Merged

Remove charset in tests #3807

merged 6 commits into from May 21, 2021

Conversation

timemachine3030
Copy link
Contributor

jasonsaayman
jasonsaayman approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonsaayman jasonsaayman merged commit dbc634c into axios:master May 21, 2021
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
@timemachine3030 @mpark86 @jasonsaayman
Remove charset in tests (axios#3807)
35581ea 
* removed charset setting when setting default header

* Remove charset from tests

Co-authored-by: mpark86 <dev.minuk.park@gmail.com>
Co-authored-by: Jay <jasonsaayman@gmail.com>
Co-authored-by: Pilot <timemachine@ctrl-c.club>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonsaayman jasonsaayman jasonsaayman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content-type header for application/json should not contain charset field, according do RFC 8259
3 participants
@timemachine3030 @jasonsaayman @mpark86