Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing maxBodyLength enforcement #3786

Merged
merged 3 commits into from Dec 23, 2021
Merged

Fixing maxBodyLength enforcement #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dc109b
Adding request body length validation on HTTP adapter
PauloRSF May 7, 2021
8bf18fe
Removing error code assertion on HTTP's body length support test
PauloRSF May 7, 2021
2b68486
Merge branch 'master' into max-body-length-fix
jasonsaayman Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/adapters/http.js
View file
Open in desktop
Expand Up @@ -101,6 +101,10 @@ module.exports = function httpAdapter(config) {
));
}

if (config.maxBodyLength > -1 && data.length > config.maxBodyLength) {
return reject(createError('Request body larger than maxBodyLength limit', config));
}

// Add Content-Length header if data exists
if (!headerNames['content-length']) {
headers['Content-Length'] = data.length;
Expand Down
1 change: 0 additions & 1 deletion test/unit/adapters/http.js
View file
Open in desktop
Expand Up @@ -456,7 +456,6 @@ describe('supports http with nodejs', function () {
setTimeout(function () {
assert.equal(success, false, 'request should not succeed');
assert.equal(failure, true, 'request should fail');
assert.equal(error.code, 'ERR_FR_MAX_BODY_LENGTH_EXCEEDED');
assert.equal(error.message, 'Request body larger than maxBodyLength limit');
done();
}, 100);
Expand Down