Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing quadratic runtime and extra memory usage when setting a maxContentLength #3738

Merged
merged 2 commits into from May 4, 2021
Merged

Fixing quadratic runtime and extra memory usage when setting a maxContentLength #3738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f15b5
Fixing quadratic runtime when setting a maxContentLength
bimbiltu Apr 10, 2021
3579135
Merge branch 'master' into perf/maxContentLength
jasonsaayman May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/adapters/http.js
View file
Open in desktop
Expand Up @@ -238,11 +238,13 @@ module.exports = function httpAdapter(config) {
settle(resolve, reject, response);
} else {
var responseBuffer = [];
var totalResponseBytes = 0;
stream.on('data', function handleStreamData(chunk) {
responseBuffer.push(chunk);
totalResponseBytes += chunk.length;

// make sure the content length is not over the maxContentLength if specified
if (config.maxContentLength > -1 && Buffer.concat(responseBuffer).length > config.maxContentLength) {
if (config.maxContentLength > -1 && totalResponseBytes > config.maxContentLength) {
stream.destroy();
reject(createError('maxContentLength size of ' + config.maxContentLength + ' exceeded',
config, null, lastRequest));
Expand Down