New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON improvements: throw if JSON parsing failed; number, boolean can be passed directly as payload for encoding to JSON #2613, #61, #907 #3688
Merged
jasonsaayman
merged 14 commits into
axios:master
from
DigitalBrainJS:feat/json-improvements
Apr 19, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c26b1b5
Draft
DigitalBrainJS 4d06575
Merge branch 'master' of https://github.com/axios/axios into feat/jso…
DigitalBrainJS bc402a7
Added support for primitive types to be converted to JSON if the requ…
DigitalBrainJS 5112ba3
Fixed isOlderVersion helper;
DigitalBrainJS aa63605
Added forcedJSONParsing transitional option #2791
DigitalBrainJS b30a737
Merge branch 'master' into feat/json-improvements
DigitalBrainJS 7cdfb90
Merge branch 'master' of https://github.com/axios/axios into feat/jso…
DigitalBrainJS ba6d2bc
`transformData` is now called in the default configuration context if…
DigitalBrainJS 07441a6
Merge remote-tracking branch 'origin/feat/json-improvements' into fea…
DigitalBrainJS bb5b761
Merge branch 'master' into feat/json-improvements
DigitalBrainJS b8bd73c
Merge branch 'master' into feat/json-improvements
DigitalBrainJS e1340e0
Added `transitional.clarifyTimeoutError` to throw ETIMEDOUT error ins…
DigitalBrainJS f2dd788
Merge branch 'master' of https://github.com/axios/axios into feat/jso…
DigitalBrainJS d7f938b
Merge remote-tracking branch 'origin/feat/json-improvements' into fea…
DigitalBrainJS File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
setTimeout
appears to be causing test failures for me when using sinon/nise FakeServer with FakeTimers in Jest. And possibly withnock
.replacing this line with
onloadend()
causes my tests to pass again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for me. Thx for pointing it out. :)
Will this be fixed in a new release, because this bug appears since v0.21.2. Is it already planned? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For one project we ended up putting
flushPromises
andawait sandbox.clock.tickAsync()
/sandbox.clock.tick
in the appropriate places in our custom wrappers for sinon FakeServer and requests to workaround this change so that we could use the latest version of axios in the project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the response :) ... the
await clock.tickAsync();
worked for me. Thanks a lot!