Fixing possible runtime error in isAxiosError.js type guard #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5argon
changed the title
AxiosError type guard can cause runtime error if payload is a `null`, since `null` also passes the check `typeof payload === 'object'`. Then the code cannot access `.isAxiosError` of a `null`. ``` TypeError: Cannot read property 'isAxiosError' of null ```
suyundukov
reviewed
Feb 1, 2021
| @@ -7,5 +7,5 @@ | |||
| * @returns {boolean} True if the payload is an error thrown by Axios, otherwise false | |||
| */ | |||
| module.exports = function isAxiosError(payload) { | |||
| return (typeof payload === 'object') && (payload.isAxiosError === true); | |||
| return (typeof payload === 'object') && (payload !== null) && (payload.isAxiosError === true); | |||
There was a problem hiding this comment.
Can't we just check if payload is truthy?
Suggested change
| return (typeof payload === 'object') && (payload !== null) && (payload.isAxiosError === true); | |
| return !!payload && (typeof payload === 'object') && (payload.isAxiosError === true); |
|
I also encountered this problem. Whenever Google Chrome runs Ajax-related code, just add debugger and click Next to jump directly to the isAxiosError.js page. How can I solve it? |
|
There is already an earlier open PR for this: #3546 |
@crush12132 Hard to know without looking at your code, but you probably just need to check if the value is not null before you check if it is an Axios error. Something like if (error !== null && axios.isAxiosError(error) {
// handle the axios error
}or if (!axios.isAxiosError(error) || error === null) {
// handle the non-axios error
}} |
|
Closed in favour of #3546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AxiosError type guard can cause runtime error if payload is a
null, sincenullalso passes the checktypeof payload === 'object'. Then the code cannot access.isAxiosErrorof anull.