Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use String.prototype.trim() if available #3446

Closed
wants to merge 1 commit into from
Closed

fix: Use String.prototype.trim() if available #3446

wants to merge 1 commit into from

Conversation

ffflorian
Copy link

@ffflorian ffflorian commented Nov 27, 2020

Using a custom RegEx to trim a string is much slower (see JSBench example) than using String.prototype.trim().

@chiefkana
Copy link

Issue should have been patched after merging this fix. #3980

@chiefkana chiefkana mentioned this pull request Sep 2, 2021
@ffflorian ffflorian closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants