Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing an issue that type 'null' and 'undefined' is not assignable to validateStatus when typescript strict option is enabled #3200

Merged
merged 1 commit into from Oct 20, 2020
Merged

Fixing an issue that type 'null' and 'undefined' is not assignable to validateStatus when typescript strict option is enabled #3200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@ export interface AxiosRequestConfig {
onUploadProgress?: (progressEvent: any) => void;
onDownloadProgress?: (progressEvent: any) => void;
maxContentLength?: number;
validateStatus?: ((status: number) => boolean | null);
validateStatus?: ((status: number) => boolean) | null;
maxBodyLength?: number;
maxRedirects?: number;
socketPath?: string | null;
Expand Down
8 changes: 8 additions & 0 deletions test/typescript/axios.ts
View file
Open in desktop
Expand Up @@ -44,6 +44,14 @@ const config: AxiosRequestConfig = {
cancelToken: new axios.CancelToken((cancel: Canceler) => {})
};

const nullValidateStatusConfig: AxiosRequestConfig = {
validateStatus: null
};

const undefinedValidateStatusConfig: AxiosRequestConfig = {
validateStatus: undefined
};

const handleResponse = (response: AxiosResponse) => {
console.log(response.data);
console.log(response.status);
Expand Down