New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a type guard for AxiosError
#2949
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e4bb90e
Adding a type guard for `AxiosError`
JasonHK 339ceca
Merge branch 'master' of https://github.com/axios/axios into feat/is-…
JasonHK d074f59
Merge branch 'master' into feat/is-axios-error
JasonHK 6209193
Merge branch 'master' into feat/is-axios-error
JasonHK 7ca4e52
Merge branch 'master' of https://github.com/axios/axios into feat/is-…
JasonHK 357afe7
Merge branch 'feat/is-axios-error' of github.com:JasonHK/axios into f…
JasonHK 02cbc34
Merge branch 'master' into feat/is-axios-error
JasonHK fbfacd7
Merge branch 'master' into feat/is-axios-error
JasonHK 99c71d1
Merge branch 'master' into feat/is-axios-error
JasonHK cdab7f3
Merge branch 'master' into feat/is-axios-error
JasonHK 17caea2
Merge branch 'master' into feat/is-axios-error
JasonHK e4963a6
Merge branch 'master' into feat/is-axios-error
JasonHK 51ab3fb
Merge branch 'master' into feat/is-axios-error
JasonHK File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
'use strict'; | ||
|
||
/** | ||
* Determines whether the payload is an error thrown by Axios | ||
* | ||
* @param {*} payload The value to test | ||
* @returns {boolean} True if the payload is an error thrown by Axios, otherwise false | ||
*/ | ||
module.exports = function isAxiosError(payload) { | ||
return (typeof payload === 'object') && (payload.isAxiosError === true); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
var createError = require('../../../lib/core/createError'); | ||
var enhanceError = require('../../../lib/core/enhanceError'); | ||
var isAxiosError = require('../../../lib/helpers/isAxiosError'); | ||
|
||
describe('helpers::isAxiosError', function () { | ||
it('should return true if the error is created by core::createError', function () { | ||
expect(isAxiosError(createError('Boom!', { foo: 'bar' }))) | ||
.toBe(true); | ||
}); | ||
|
||
it('should return true if the error is enhanced by core::enhanceError', function () { | ||
expect(isAxiosError(enhanceError(new Error('Boom!'), { foo: 'bar' }))) | ||
.toBe(true); | ||
}); | ||
|
||
it('should return false if the error is a normal Error instance', function () { | ||
expect(isAxiosError(new Error('Boom!'))) | ||
.toBe(false); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeof null === 'object'
=>true
Should be changed to:
({}).toString.call(payload) === '[obejct Object]'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to make a strict inspection here? @jasonsaayman @JasonHK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I totally forgot about this. But because this PR had already been merged, I will open another PR to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have submitted the relevant PR: #3546