New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regular expressions in isValidXss
#2671
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
40c5be3
Fix: narrow down the words start with "on" and end with "="
ZeroCho 3a0d3c3
Test for Fix: #2670
ZeroCho 589088a
Add: focus series, change, blur, input, drag, resize
ZeroCho 45bbe1a
Separate eventRegex and JSRegex
ZeroCho ad4f75a
Add scroll
ZeroCho 17f9ca0
For #2646
ZeroCho f8e3f69
For #2646
ZeroCho 428ed52
Add touch events
ZeroCho fddcc24
Add gi flag
ZeroCho 8506b90
Test for case insensitive issue
ZeroCho File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
'use strict'; | ||
|
||
module.exports = function isValidXss(requestURL) { | ||
var xssRegex = /(\b)(on\w+)=|javascript|(<\s*)(\/*)script/gi; | ||
return xssRegex.test(requestURL); | ||
var xssEventRegex = /(\b)on(click|error|load|mouse\w+|key\w+|focus\w?|blur|change|input|drag\w?|touch\w+|resize|dbclick|contextmenu|drop|select|message|scroll)=/gi; | ||
var xssJSRegex = /javascript:|(<\s*)(\/*)script/gi; | ||
return xssJSRegex.test(requestURL) || xssEventRegex.test(requestURL); | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separated into two regex for readablity