Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'includes' API, fix CI build failure #2574

Merged
merged 4 commits into from Dec 9, 2019
Merged

Remove 'includes' API, fix CI build failure #2574

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06533df
Remove 'includes' API, fix CI build failure
Alanscut Nov 27, 2019
33c8895
request change
Alanscut Dec 6, 2019
ba16c9a
request changes
Alanscut Dec 6, 2019
c0c7d05
Merge branch 'master' into CI-Error-includes
Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions lib/utils.js
View file
Open in desktop
Expand Up @@ -18,6 +18,15 @@ function isArray(val) {
return toString.call(val) === '[object Array]';
}

/**
* Determine if a value is undefined
*
* @param {Object} val The value to test
* @returns {boolean} True if the value is undefined, otherwise false
*/
function isUndefined(val) {
return typeof val === 'undefined';
}

/**
* Determine if a value is a Buffer
Expand All @@ -26,7 +35,8 @@ function isArray(val) {
* @returns {boolean} True if value is a Buffer, otherwise false
*/
function isBuffer(val) {
return ![undefined, null].includes(val) && val.constructor === Buffer;
return val !== null && !isUndefined(val) && val.constructor !== null && !isUndefined(val.constructor)
&& typeof val.constructor.isBuffer === 'function' && val.constructor.isBuffer(val);
}

/**
Expand Down Expand Up @@ -85,16 +95,6 @@ function isNumber(val) {
return typeof val === 'number';
}

/**
* Determine if a value is undefined
*
* @param {Object} val The value to test
* @returns {boolean} True if the value is undefined, otherwise false
*/
function isUndefined(val) {
return typeof val === 'undefined';
}

/**
* Determine if a value is an Object
*
Expand Down