Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'geturi' method for more information #2555

Closed
wants to merge 3 commits into from

Conversation

Alanscut
Copy link
Collaborator

Changes:

  • According to the content provided in the configuration, the method will return as much information as possible, including protocol, domain, port, path, query, etc
  • Fiix for axios.getUri doesn't use baseURL #2468

note:

The hash mark will lost because it only guides the browser and has no effect on the server at all

@mrcljx
Copy link

mrcljx commented Apr 24, 2020

Anything stopping the merge?

@utluiz
Copy link

utluiz commented Apr 24, 2020

I'd love to see this change however I'd like to point out that a better approach would be creating a new API method and deprecating the current one, rather than just changing existing behavior.

Let's say I'm using a previous version and and I have something like baseURL + config.getUri(config). Now my code works but logic is broken at runtime without warning.

@jasonsaayman
Copy link
Member

We would not be able to merge this without making a breaking change so i think for now we are going to have to leave it as is. We would like to present a v0.20.0 to the community soon that will mend all instability in Axios and then start working on features from there.

I will keep this open and maybe we can look at it in a next version after we have gain stability again.

@jasonsaayman
Copy link
Member

Hi,

I am closing this as it is too old to reliably merge. Please open a new pull request should you want to add this functionality within the confines of the latest Axios version.

Thanks

@sakarit-zz
Copy link
Contributor

Opened a new PR #3737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants