Fixing getting local files (file://) failed #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasuf
reviewed
Oct 25, 2019
lib/core/settle.js
Outdated
| @@ -11,7 +11,8 @@ var createError = require('./createError'); | |||
| */ | |||
| module.exports = function settle(resolve, reject, response) { | |||
| var validateStatus = response.config.validateStatus; | |||
| if (!validateStatus || validateStatus(response.status)) { | |||
| var responseUrl = response.config.url; | |||
| if (!validateStatus || validateStatus(response.status) || (!response.status && ~responseUrl.indexOf('file:'))) { | |||
There was a problem hiding this comment.
the tilde bitwise logic returns -1 when the string doesn't match and 0 when it matches, I believe it will always be false? unless I'm missing something
> myString = "test123"
"test123"
> ~myString.indexOf("test");
-1
> ~myString.indexOf("notpresent");
0You can just do the normal .indexOf('file:') >= 0 or something similar
There was a problem hiding this comment.
hi, -1 is true rather than false...
var i = -1;
if (i) {
console.log(i, " is true");
} else {
console.log(i, " is false");
}
it will ouput: -1 ' is true'
|
and about the build, we're working on it, hopefully we have it passing soon |
|
Thanks @yasuf ! |
yasuf
approved these changes
Oct 25, 2019
|
Hi @yasuf , since you have approved this PR, will you merge it? |
chinesedfan
suggested changes
Feb 16, 2020
chinesedfan
suggested changes
Mar 12, 2020
chinesedfan
approved these changes
Mar 12, 2020
chinesedfan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing issue #2416 and #2396