Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make redirection from HTTP to HTTPS work #2426

Merged
merged 2 commits into from Sep 26, 2019
Merged

Make redirection from HTTP to HTTPS work #2426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03171f5
Make redirection from HTTP to HTTPS work
JitixPhotobox Sep 24, 2019
7c2c7d3
Merge branch 'master' into patch-1
felipewmartins Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/adapters/http.js
View file
Open in desktop
Expand Up @@ -85,6 +85,10 @@ module.exports = function httpAdapter(config) {
method: config.method.toUpperCase(),
headers: headers,
agent: agent,
agents: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JitixPhotobox i see in the follow-redirects documentation that the object should be:

agents: {
  https: Agent,
  http: Agent
}

Or am I missing something?

httpsAgent: config.httpsAgent,
httpAgent: config.httpAgent
},
auth: auth
};

Expand Down