Fixing response with utf-8 BOM can not parse to json #2419
Merged
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saying I'd love to see this merged as I have to use an annoying workaround to use Axios with our legacy .Net services. (They all return a BOM character.) |
|
@Morgul I think you can solve it by add another |
|
@chinesedfan That works, as a work around, but I'd love to see this merged in, as axios is one of the few libraries that doesn't automatically work around this issue. 🙁 |
|
@Morgul Would you mind to list some examples? I am glad to check their implementations. And also make preparations for some users who want to keep those BOMs. |
|
@chinesedfan Here are some examples to avoid these problems. (Windows system save file with BOM, but not all HTTP services handle it) |
jasonsaayman
added a commit
that referenced
this pull request
Jul 1, 2020
* add checkServerIdentity to request config for http adapter * add checkServerIdentity unit test * add checkServerIdentity doc * add more unit tests for checkServerIdentity * remove ssl-root-cas dependency * add changes description to changelog * Fixing response with utf-8 BOM can not parse to json (#2419) * fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com> * Update mergeConfig.js Co-authored-by: Yasu Flores <carlosyasu91@gmail.com> Co-authored-by: Cr <631807682@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com>
jasonsaayman
added a commit
that referenced
this pull request
Jul 2, 2020
* fix: only set responseType 'json' or use defaulte responseType return JSON response * test: change defalut transform behaviour * refactor: try to parse json * fix: code style * test: response type json * fix: set default transformResponse to empty array * chore: code style * Fixing response with utf-8 BOM can not parse to json (#2419) * fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com> * Update http.js * Fix trailing spaces * fix: strip Bom before parse to json Co-authored-by: Alanscut <948467222@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com> Co-authored-by: Cr <a631807682@qq.com>
gwdp
pushed a commit
to ikon-integration/axios
that referenced
this pull request
Jul 17, 2020
* fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com>
gwdp
pushed a commit
to ikon-integration/axios
that referenced
this pull request
Jul 17, 2020
* fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com>
IvanStoilov
pushed a commit
to IvanStoilov/axios
that referenced
this pull request
Nov 25, 2020
* add checkServerIdentity to request config for http adapter * add checkServerIdentity unit test * add checkServerIdentity doc * add more unit tests for checkServerIdentity * remove ssl-root-cas dependency * add changes description to changelog * Fixing response with utf-8 BOM can not parse to json (axios#2419) * fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com> * Update mergeConfig.js Co-authored-by: Yasu Flores <carlosyasu91@gmail.com> Co-authored-by: Cr <631807682@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com>
IvanStoilov
pushed a commit
to IvanStoilov/axios
that referenced
this pull request
Nov 25, 2020
* fix: only set responseType 'json' or use defaulte responseType return JSON response * test: change defalut transform behaviour * refactor: try to parse json * fix: code style * test: response type json * fix: set default transformResponse to empty array * chore: code style * Fixing response with utf-8 BOM can not parse to json (axios#2419) * fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com> * Update http.js * Fix trailing spaces * fix: strip Bom before parse to json Co-authored-by: Alanscut <948467222@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com> Co-authored-by: Cr <a631807682@qq.com>
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
* fix: remove byte order marker (UTF-8 BOM) when transform response * fix: remove BOM only utf-8 * test: utf-8 BOM * fix: incorrect param name Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services(deploy on
Windows) will response data withBOMthat can not parse it tojson.see #1768 (comment)