Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webpack + deps, remove now unnecessary polyfills #2410

Merged
merged 4 commits into from Oct 21, 2019
Merged

Update Webpack + deps, remove now unnecessary polyfills #2410

merged 4 commits into from Oct 21, 2019

Commits on Oct 17, 2019

  1. Update deps 

     * handles webpack 1 -> 4 migration
    @avindra
    avindra committed Oct 17, 2019
    Copy the full SHA
    cd4726c View commit details
    Browse the repository at this point in the history

  2. remove promise helpers from dev files 

    assume `Promise` is available, or polyfilled by
the consumer
    @avindra
    avindra committed Oct 17, 2019
    Copy the full SHA
    53b8955 View commit details
    Browse the repository at this point in the history

  3. Remove trim util 

    String.protoype.trim has good coverage (including IE9)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim

Also, the http adapter already uses the native method.
    @avindra
    avindra committed Oct 17, 2019
    Copy the full SHA
    ab6713f View commit details
    Browse the repository at this point in the history

  4. Remove isArray util. isArray has good coverage, even 

       in IE9. So lets remove the custom polyfill.

 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray

also resolves a few lint issues
    @avindra
    avindra committed Oct 17, 2019
    Copy the full SHA
    ac2858e View commit details
    Browse the repository at this point in the history