Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not modify config.url when using a relative baseURL (resolves #1628) #2391

Merged
merged 2 commits into from Sep 5, 2019
Merged

Do not modify config.url when using a relative baseURL (resolves #1628) #2391

merged 2 commits into from Sep 5, 2019

Commits on Sep 5, 2019

  1. Adding tests to show config.url mutation 

    Because config.url is modified while processing the request
when the baseURL is set,
it is impossible to perform a retry with the provided config object.

Ref axios#1628
    @multicolaure
    multicolaure committed Sep 5, 2019
    Copy the full SHA
    7dff012 View commit details
    Browse the repository at this point in the history

  2. Fixing url combining without modifying config.url 

    As config.url is not modified anymore during the request processing.
The request can safely be retried after it failed with the provided
config.

resolves axios#1628
    @multicolaure
    multicolaure committed Sep 5, 2019
    Copy the full SHA
    4f546cc View commit details
    Browse the repository at this point in the history