Modernized typechecks #2255
Closed
Modernized typechecks #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasuf
reviewed
Oct 25, 2019
| function isArrayBuffer(val) { | ||
| return toString.call(val) === '[object ArrayBuffer]'; | ||
| function isBuffer(val) { | ||
| return val && val.constructor && typeof val.constructor.isBuffer === 'function' && val.constructor.isBuffer(val); |
There was a problem hiding this comment.
The nice thing about the dependency was that it had tests, do you mind adding some tests?
|
Hi, Thank you for the contribution. This includes the compiled files as well as not having tests, closing for now, please re-submit if you fix the mentioned issues. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modernizes typecheck functions in utils in order to reduce dependency count and reduce bundled dist sizes.
is-bufferfrom package dependencies (Remove dependency of is-buffer, inlining instead #1941), or as also implemented in (Remove dependency on is-buffer #1816 )Array.isArraymethod - ES2015UPGRADE_GUIDE.mdfrom npm bundle to reduce sizeResults
Dist
before:
4740B
after:
4595B
total:
145B (~3.1%)
NPM
before:
83.6 kB
after:
82.1 kB
total:
1.5kB (~1.2%)
Notes
I tried a number of things on the side, this addresses some low-hanging fruits, but I think that the size of the bundle can be cut down significantly more. Let me know if that something that would be interesting.