Fix params merging

[zackseuberling]

Fixes bug introduced in 0.19.0 where request params are not being merged correctly with default instance params. See bug #2190 for more information

According to the documentation:

The available instance methods are listed below. The specified config will be merged with the instance config.

Tests were failing because of the change to merge params, so hopefully my update to the tests is correct … and passes

[nothingismagick]

Nice job @zackseuberling

[jasonsaayman]

@emilyemorehouse, I tested this one locally and it seems good. I do agree with @zackseuberling that there has been a change from 0.18 to 0.19. You can run it in over here and see the behavior is different.

[kodmunki]

0.19.0 is breaking our services. The root cause appears to be what this is fixing. What kind of timeline on a merge and release? 🤓🍻

[jasonsaayman]

@kodmunki I cannot merge the changes, we will need to wait for @emilyemorehouse. I'm sure it will be done soon.

[lsagetlethias]

I think maybe this PR should be passed alongside this one: #2207 because more than one BC was induced by mergeConfig function.

[samerdernaika]

plz merge it

[code-a-cola]

Do we have an update as to when this is getting merged?

[nothingismagick]

I would just like to say that we (at quasarframework) are still recommending that people pin 0.18.1, and I have to agree that @code-a-cola is right - it would be good to update us on this issue / PR.

[ibrainventures]

@emilyemorehouse .. thanks for your work on this project .. it qould be great and neefull to see this pr merged! :-)

[avindra]

I ran grunt karma:single against master after #2207 got merged.

@zackseuberling your test breaks against master, so PR 2207 seemed to be solving another issue:

Chrome 77.0.3865 (Linux 0.0.0) core::mergeConfig should merge auth, headers, params, proxy with defaults FAILED
	Expected $.params to have properties
	    foo: 'test'
	    at UserContext.<anonymous> (webpack:///test/specs/core/mergeConfig.spec.js:50:78 <- test/specs/core/mergeConfig.spec.js:96:83)
................................................................................
.....................................
Firefox 68.0.0 (Linux 0.0.0) core::mergeConfig should merge auth, headers, params, proxy with defaults FAILED
	Expected $.params to have properties
	    foo: 'test'
	@webpack:///test/specs/core/mergeConfig.spec.js:50:78 <- test/specs/core/mergeConfig.spec.js:96:83
................................................................................

[Alanscut]

@zackseuberling , code is updated, please resolve the conflicts, thanks!

[yasuf]

would you mind adding tests to this change?

[yasuf]

and fixing the existing tests

[zackseuberling]

@yasuf I can no longer get the test suite to run for me, so it is quite hard for me to fix or change any tests. I rebased and force-updated so I lost the changes to tests I had written earlier.

[chinesedfan]

Closed in favor of #2656. Cheers.