Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for method options type definitions #1996

Merged
merged 3 commits into from Mar 7, 2020
Merged

Adding tests for method options type definitions #1996

merged 3 commits into from Mar 7, 2020

Conversation

GreenTeaCake
Copy link

Adds missing TS type definition for AxiosInstance#options and closes #1990
Relates to #461

@GreenTeaCake GreenTeaCake changed the title Adding AxiosInstance#options TS type defeinition. Adding AxiosInstance#options TS type definition. Feb 11, 2019
@GreenTeaCake
Copy link
Author

@emilyemorehouse Hello! Using your invitation

Feel free to ping me if I don't respond after a few days.

Could you please take a look at the code?

@zegenie
Copy link

zegenie commented Jun 5, 2019

Any chance this gets merged soon?

@chinesedfan chinesedfan changed the title Adding AxiosInstance#options TS type definition. Adding tests for method options type definitions Mar 7, 2020
@chinesedfan
Copy link
Collaborator

@grumblerchester The type definition has been added by #2341. But still glad to add some tests. Thanks for your contribution.

@chinesedfan chinesedfan merged commit c98ce7d into axios:master Mar 7, 2020
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interface AxiosInstance is missing 'options' method
5 participants