Fixing ignore set withCredentials false

[tonwe]

Explicit to set a true or false setting.
if (typeof config.withCredentials !== 'undefined') {
request.withCredentials = !!config.withCredentials;
}

[kimihiro64]

@LcTwisk Can someone please merge this? An invalid cookie got accidentally placed in cookie jar and now all my api requests fail...

[waeltken]

This is looking good! Looks like i need this too... 👍

[kimihiro64]

Bump @waeltken @emilyemorehouse

This has been sitting here for months, we go live in a month and this is still causing issues if I don't hack this patch in every build...

[gokhandoslu]

until this pull request completed, you can use the workaround below

create a file named postinstall.sh and add the codes below

#!/usr/bin/env bash

find ./node_modules/axios/lib/adapters/xhr.js -type f -exec sed -i '' -e 's|Add withCredentials to request if needed|Add withCredentials to request if needed. Explicit to set a true or false|g' {} \;
find ./node_modules/axios/lib/adapters/xhr.js -type f -exec sed -i '' -e 's|if (config.withCredentials) {|if (typeof config.withCredentials !== "undefined") {|g' {} \;
find ./node_modules/axios/lib/adapters/xhr.js -type f -exec sed -i '' -e 's|request.withCredentials = true;|request.withCredentials = !!config.withCredentials;|g' {} \;

add a postinstall script into package.json
"postinstall": "sh postinstall.sh"

[Alanscut]

LGTM! this will fix #1837

[Alanscut]

please use the isUndefined function of utils.

axios/lib/utils.js

Lines 84 to 86 in 8414664

	function isUndefined(val) {
	return typeof val === 'undefined';
	}

[bxjx]

Bump on this please! Just hit this issue and am having to use this patch (thanks @gokhandoslu !).

@tonwe @Alanscut, happy to redo pull request if it's stuck waiting on that feedback?

[bxjx]

If it helps, I've created a new PR with the feedback #2591. Thanks to everyone on this thread for solutions!

[chinesedfan]

Closed in favor of #2582. Apologize for the late response.