Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom config #1831

Closed
wants to merge 6 commits into from
Closed

feat: Allow custom config #1831

wants to merge 6 commits into from

Conversation

Khaledgarbaya
Copy link
Collaborator

@Khaledgarbaya Khaledgarbaya commented Oct 15, 2018

Fixes #1718

Copy link
Member

@emilyemorehouse emilyemorehouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation on what this can be used for and how to use it?

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Khaledgarbaya <khaledgarbaya@gmail.com>
@aidant
Copy link

aidant commented Feb 11, 2019

This is something I really look forward to since I frequently run into situations where custom configuration is incredibly helpful. However I suggest we call the property custom rather than customConfig since it adds unneeded content especially when used as config.customConfig.

Edit: I also remember seeing a similar PR however the object was userData.

@yasuf
Copy link
Collaborator

yasuf commented Nov 23, 2019

This is already fixed and will be released as part of 0.19.1, seehttps://github.com//pull/2207

@yasuf yasuf closed this Nov 23, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
@jasonsaayman jasonsaayman deleted the feat/customConfig branch May 22, 2020 19:05
@jasonsaayman jasonsaayman restored the feat/customConfig branch May 22, 2020 19:05
@jasonsaayman jasonsaayman deleted the feat/customConfig branch May 22, 2020 19:06
@jasonsaayman jasonsaayman restored the feat/customConfig branch May 22, 2020 19:06
@jasonsaayman jasonsaayman deleted the feat/customConfig branch May 22, 2020 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#1395 breaks custom config
5 participants