Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating xhr adapter to inherit withCredentials flag from the config #1441

Closed
wants to merge 1 commit into from
Closed

Updating xhr adapter to inherit withCredentials flag from the config #1441

wants to merge 1 commit into from

Commits on Mar 28, 2018

  1. Updating xhr adapter to inherit withCredentials flag from the config 

    This change is necessary to allow updating withCredentials XHR flag in React Native environment where for historic reasons unlike on web the default value is `true`.

See the default being set to true here: https://github.com/facebook/react-native/blob/26684cf3adf4094eb6c405d345a75bf8c7c0bf88/Libraries/Network/XMLHttpRequest.js#L133

Prior this change we would only update withCredentials XHR flag if the config was set to true. Now we just pass through the config value as long as it is specified. This does not affect the default behaviour as if the flag wasn't set in the config we won't set it on XHR request either.
    @kmagiera
    kmagiera committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    8f16ba2 View commit details
    Browse the repository at this point in the history