Updating type of Rejection Error thrown from Axios to AxiosError #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend, forEach, merge and trim are replaced by lodash
Khaledgarbaya
force-pushed
the
release/1.0.0
branch
from
48a9588
to
93deda4
Compare
|
Closed in favor of #1419. Please reopen if deemed necessary in v1.0.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all axios rejections in Javascript are of type
Error, making it differentiate between different rejection reasons.This PR introduces a custom error type
AxiosErrorwhich can be used by users to determine if the error returned is from axios or not.Aims to fix the issue more concretely than #1419