Adjust specs to work with new lib interface #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend, forEach, merge and trim are replaced by lodash
48 tasks
test/specs/basicAuth.spec.js
Outdated
| it('should accept HTTP Basic auth with username/password', function (done) { | ||
| axios.get('/foo', { | ||
| auth: { | ||
| username: 'Aladdin', |
There was a problem hiding this comment.
isn't Alibaba who said that 🙈
There was a problem hiding this comment.
Hahahaha, I just copy & 🍝 it, but yeah you're right 😂
Khaledgarbaya
approved these changes
Feb 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Umbrella: #1333
As later on documented in the Changelog:
btoaPolyfill anymoreaxios()interface will be removed,axios.request()and the method shorthand methods are the way to gotest/specs/utils:trim,merge,forEach&extendare removed, they will be superseded by their lodash equivalents