New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust karma to use Webpack 3 config #1339
Adjust karma to use Webpack 3 config #1339
Conversation
Sauce Labs Result:
Looks like it does what it should. Fixing the tests itself is another PR, I guess @zcei? |
IMHO this PR could also get rid of grunt, it is only used for testing (this pr + #1336), building (already rewritten and merged to release/1.0.0) and for bundeling to bower (which should get removed IMHO, bower is obsolete) I am also happy to do this in a separate PR, would be a pleasure to simplify the build process further :) See here:
|
Sure, I just kept that for visibility. As we currently have no replacement for At least something for coverage would be nice in mid-term. But probably CodeCov instead of CoverAlls? |
Next PR is adjusting the tests itselfs (removing some tests that will be obsolete, requiring instead of globals, etc) In "TDD" approach the tests will get fixed by the PRs to come. |
regarding banner: i guess we can just remove it |
0aeaba6
to
21ae581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Umbrella: #1333
This PR adjust the Karma spec runner to use the same Webpack config that is used for production builds.
There is no need to have the webpack dev server running - when it was still included the bundle was emitted multiple times, without we get a single bundle that the test suite is run against.