Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust karma to use Webpack 3 config #1339

Merged

Conversation

zcei
Copy link
Contributor

@zcei zcei commented Feb 6, 2018

Umbrella: #1333

This PR adjust the Karma spec runner to use the same Webpack config that is used for production builds.

There is no need to have the webpack dev server running - when it was still included the bundle was emitted multiple times, without we get a single bundle that the test suite is run against.

@axe312ger
Copy link
Contributor

Sauce Labs Result:

IE 11.0.0 (Windows 8.1 0.0.0): Executed 178 of 178 (93 FAILED) (0.834 secs / 0 secs)
IE 9.0.0 (Windows 7 0.0.0): Executed 178 of 178 (90 FAILED) (1.1 secs / 0 secs)
Firefox 58.0.0 (Windows 7 0.0.0): Executed 178 of 178 (93 FAILED) (0.48 secs / 0 secs)
Safari 9.1.2 (Mac OS X 10.11.6): Executed 178 of 178 (93 FAILED) (0.474 secs / 0 secs)
Edge 16.16299.0 (Windows 10 0.0.0): Executed 178 of 178 (93 FAILED) (0.676 secs / 0 secs)
Chrome 64.0.3282 (Windows 7 0.0.0): Executed 178 of 178 (93 FAILED) (0.47 secs / 0 secs)
IE 10.0.0 (Windows 8 0.0.0): Executed 178 of 178 (93 FAILED) (1.057 secs / 0 secs)
TOTAL: 648 FAILED, 598 SUCCESS

Looks like it does what it should. Fixing the tests itself is another PR, I guess @zcei?

@axe312ger
Copy link
Contributor

IMHO this PR could also get rid of grunt, it is only used for testing (this pr + #1336), building (already rewritten and merged to release/1.0.0) and for bundeling to bower (which should get removed IMHO, bower is obsolete)

I am also happy to do this in a separate PR, would be a pleasure to simplify the build process further :)

See here:

  grunt.registerTask('test', 'Run the jasmine and nodeunit tests', ['eslint', 'nodeunit', 'karma:single', 'ts']);
  grunt.registerTask('build', 'Run webpack and bundle the source', ['clean', 'webpack']);
  grunt.registerTask('version', 'Sync version info for a release', ['usebanner', 'package2bower']);

@zcei
Copy link
Contributor Author

zcei commented Feb 6, 2018

Sure, I just kept that for visibility. As we currently have no replacement for usebanner & coverage.

At least something for coverage would be nice in mid-term. But probably CodeCov instead of CoverAlls?
Then I'd be fine with just getting rid of everything now and introduce proper new tooling later.

@zcei
Copy link
Contributor Author

zcei commented Feb 6, 2018

Fixing the tests itself is another PR, I guess @zcei?

Next PR is adjusting the tests itselfs (removing some tests that will be obsolete, requiring instead of globals, etc)

In "TDD" approach the tests will get fixed by the PRs to come.

@Khaledgarbaya Khaledgarbaya added this to the v1.0.0 milestone Feb 6, 2018
@axe312ger
Copy link
Contributor

axe312ger commented Feb 6, 2018

regarding banner: i guess we can just remove it
regarding coverage: It should already gather coverage information, switching to codecov would be 👍 from my side but should be a separate PR IMHO

@Khaledgarbaya Khaledgarbaya self-requested a review February 9, 2018 09:54
@Khaledgarbaya Khaledgarbaya added this to To Do in 1.0.0 via automation Feb 9, 2018
@Khaledgarbaya Khaledgarbaya mentioned this pull request Feb 9, 2018
48 tasks
@Khaledgarbaya Khaledgarbaya moved this from To Do to In progress in 1.0.0 Feb 9, 2018
@zcei zcei force-pushed the release/1.0.0-adjust-karma branch from 0aeaba6 to 21ae581 Compare February 9, 2018 11:26
Copy link
Collaborator

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khaledgarbaya Khaledgarbaya merged commit c2c2b98 into axios:release/1.0.0 Feb 9, 2018
1.0.0 automation moved this from In progress to Done Feb 9, 2018
@Khaledgarbaya Khaledgarbaya deleted the release/1.0.0-adjust-karma branch February 9, 2018 12:07
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
1.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants