Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to bypass proxy #434

Closed
chasetec opened this issue Sep 2, 2016 · 9 comments
Closed

Need to bypass proxy #434

chasetec opened this issue Sep 2, 2016 · 9 comments

Comments

@chasetec
Copy link

chasetec commented Sep 2, 2016

I have some endpoints that my proxy server doesn't handle well and in my NodeJS environment the http_proxy environment is set.

Can you honor the no_proxy environmental variable and/or allow a config option to disable proxy usage?

I'm using axios@0.13.1 for now.

@nickuraltsev
Copy link
Member

I agree that axios should honor the no_proxy env variable. As for a config option, we can use the existing option for that: if proxy is explicitly set to null or false, ignore proxy env variables.

Are you interested in creating a PR for this?

@cesarp
Copy link

cesarp commented Nov 15, 2016

@nickuraltsev I can help with the fix since I need it too but I am unable to run the unit tests so not sure if I am breaking something else.

@nickuraltsev
Copy link
Member

@cesarp What's going on with unit tests?

@cesarp
Copy link

cesarp commented Nov 16, 2016

The unit tests hang on my Linux machine but work properly in macOS

@vilinski
Copy link

Hi! Is there any progress with this PR? thx

vbfox added a commit to vbfox/axios that referenced this issue Feb 7, 2017
When the proxy field in configuration is === false all proxy processing is
disabled. This specifically disable the 'http_proxy' environment variable
handling.

Fixes axios#635
Related to axios#434
vbfox added a commit to vbfox/axios that referenced this issue Mar 20, 2017
When the proxy field in configuration is === false all proxy processing is
disabled. This specifically disable the 'http_proxy' environment variable
handling.

Fixes axios#635
Related to axios#434
vbfox added a commit to vbfox/axios that referenced this issue Mar 20, 2017
When the proxy field in configuration is === false all proxy processing is
disabled. This specifically disable the 'http_proxy' environment variable
handling.

Fixes axios#635
Related to axios#434
@lucastheisen
Copy link

Yeah, this one just bit me too: http://stackoverflow.com/q/43433380/516433. No idea it was using https_proxy, and http_proxy but ignoring no_proxy... Was frustrating to figure out, and would be really useful to have it be consistent.

vbfox added a commit to vbfox/axios that referenced this issue Apr 28, 2017
When the proxy field in configuration is === false all proxy processing is
disabled. This specifically disable the 'http_proxy' environment variable
handling.

Fixes axios#635
Related to axios#434
rubennorte pushed a commit that referenced this issue Aug 14, 2017
* Adding a way to disable all proxy processing

When the proxy field in configuration is === false all proxy processing is
disabled. This specifically disable the 'http_proxy' environment variable
handling.

Fixes #635
Related to #434

* Change readme wording

From review comment on PR (#691)
hgranlund added a commit to hgranlund/passport-keycloak-bearer that referenced this issue Nov 6, 2018
@Alanscut
Copy link
Collaborator

Fixed by #691 and #1693

@cawoodm
Copy link

cawoodm commented Dec 4, 2019

Was this resolved? We're seeing axios 0.19.0 ignore no_proxy=localhost;*.my.internal.domain;127.0.0.* and try to hit the proxy for localhost.

@cawoodm
Copy link

cawoodm commented Dec 4, 2019

Oh, it seems it expects commas no_proxy=localhost,*.my.internal.domain,127.0.0.*

@axios axios locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants