Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency of is-buffer, inlining instead #1941

Closed
jacksonStone opened this issue Dec 30, 2018 · 1 comment
Closed

Remove dependency of is-buffer, inlining instead #1941

jacksonStone opened this issue Dec 30, 2018 · 1 comment

Comments

@jacksonStone
Copy link

jacksonStone commented Dec 30, 2018 •
edited

Summary

Considering the is-buffer library exports about two lines of code (https://github.com/feross/is-buffer/blob/master/index.js) it may be nice to just inline it into a file included in the project, rather than requiring it as a dependency. Cut Axios's number of dependencies by 50% in a snap!

Context

  • axios version: 0.18.0
@fed135 fed135 mentioned this issue Jun 28, 2019
Closed
@chinesedfan
Copy link
Collaborator

Landed in #1816.

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chinesedfan @jacksonStone