Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axios should set maxBodyLength on follow-redirects to match maxContentLength #1286

Closed
mividtim opened this issue Jan 11, 2018 · 3 comments
Closed

Axios should set maxBodyLength on follow-redirects to match maxContentLength #1286

mividtim opened this issue Jan 11, 2018 · 3 comments

Comments

@mividtim
Copy link

mividtim commented Jan 11, 2018 •
edited

Summary

follow-redirects defaults to a maxBodyLength of 10mb. axios does not override this default, even when the config specifies a maxContentLength parameter greater than 10mb, thus capping axios at a maximum content length of 10mb no matter what is configured, and returning an error that does not make it obvious that follow-redirects is the cause.

axios should set the maxBodyLength option sent to follow-redirects to match the maxContentLength config property set on the AxiosOptions object.

Context

  • axios version: v0.17.1
  • Environment: Electron v1.4.3 or Node v6.5.0 with XHR polyfill, macOS v10.13.2

Status

Pull request: #1287
@mividtim mividtim mentioned this issue Jan 11, 2018
Merged
@chenchengwork
Copy link

same problem

@Khaledgarbaya Khaledgarbaya mentioned this issue Jan 30, 2018
Closed
@mividtim
Copy link
Author

PR: #1287

@qinezh qinezh mentioned this issue Feb 5, 2018
Merged
@mividtim mividtim mentioned this issue Feb 8, 2018
Closed
48 tasks
emilyemorehouse added a commit that referenced this issue Feb 11, 2018
@emilyemorehouse
Merge pull request #1357 from emilyemorehouse/fix/1286
40b8299 
Companion for #1286 and #1287 - also updating follow-redirects version in package.json
@mividtim
Copy link
Author

@chenchengwork The PR was merged, in case you care enough to use the Github version of axios - or, I guess, wait for the next release.

@renovate renovate bot mentioned this issue Mar 22, 2018
Merged
@Heimschmiede Heimschmiede mentioned this issue Jul 29, 2019
Closed
@aidanok aidanok mentioned this issue Nov 20, 2019
Merged
@chinesedfan chinesedfan mentioned this issue Jan 27, 2020
Closed
@axios axios locked and limited conversation to collaborators May 22, 2020
mbargiel pushed a commit to mbargiel/axios that referenced this issue Jan 27, 2022
@emilyemorehouse
Fixes axios#1286 - also updating follow-redirects version in package.…
d7a2fd9 
…json to ensure that maxBodyLength option is supported
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Khaledgarbaya @chenchengwork @mividtim