Set maxBodyLength on follow-redirects to match maxContentLength on AxiosOptions #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 11, 2018 08:55
|
@Khaledgarbaya Please review and merge. |
|
pretty please? |
|
Does this project have any active maintainers? I have two open PRs, passing tests, improving functionality, and not a peep for almost a month, after several pings. |
|
The commit history doesn't seem too terrible stale, so hopefully it's not dead. |
|
There was a call for assistance about a month ago (http://www.mattzabriskie.com/blog/axios-help-wanted). A few of us have stepped up, along with the original owners, and are working hard to get through the backlog of issues and PRs. Bear with us! |
emilyemorehouse
approved these changes
Feb 11, 2018
|
@emilyemorehouse Sorry for being short. I just started using this project fairly recently, so I must have missed the call to action, or it just didn't reach me on channels I was watching. I'd love to pitch in any way I can. Could you lead me in the right direction? Thanks for the merge! |
|
When will this be part of a released version available through NPM? Could we at least get a tag for this? |
|
@mividtim No worries! The squeaky wheel gets the grease, right? In terms of helping out, I've been trying to clear out the backlog of issues by determining which ones are really bugs and which are issues with a user's implementation. I'll usually start by providing a working example (unless I can reproduce a bug) or even just pinging old issues to see if they'll still respond. Feel free to reach out to me if you want more info or collaboration, I'm quite accessible on the internet. @dnfield I'll ping the person who's acting as a release manager, we definitely need an updated release. |
|
I'm now a person who can cut releases 🤷♀️ |
ramijarrar
added a commit
to fractal-code/meteor-azure
that referenced
this pull request
Mar 5, 2018
Temporary version pinning was shown to be insufficient by #52. Since axios/axios#1287 this is no longer blocking upstream. Setting 'maxContentLength' now properly resolves this once and for all.
ramijarrar
added a commit
to fractal-code/meteor-azure
that referenced
this pull request
Mar 5, 2018
Temporary version pinning was shown to be insufficient by #52. Since axios/axios#1287 this is no longer blocking upstream. Setting 'maxContentLength' now properly resolves this once and for all.
targos
added a commit
to cheminfo/zenodo
that referenced
this pull request
Apr 11, 2018
jimthedev
pushed a commit
to commitizen/cz-cli
that referenced
this pull request
May 24, 2018
This Pull Request updates dependency [axios](https://github.com/axios/axios) from `v0.15.2` to `v0.18.0` <details> <summary>Release Notes</summary> ### [`v0.18.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0180-Feb-19-2018) [Compare Source](axios/axios@v0.17.1...v0.18.0) - Adding support for UNIX Sockets when running with Node.js ([#​1070](`axios/axios#1070)) - Fixing typings ([#​1177](`axios/axios#1177)): - AxiosRequestConfig.proxy: allows type false - AxiosProxyConfig: added auth field - Adding function signature in AxiosInstance interface so AxiosInstance can be invoked ([#​1192](`axios/axios#1192), [#​1254](`axios/axios#1254)) - Allowing maxContentLength to pass through to redirected calls as maxBodyLength in follow-redirects config ([#​1287](`axios/axios#1287)) - Fixing configuration when using an instance - method can now be set ([#​1342](`axios/axios#1342)) --- ### [`v0.17.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0171-Nov-11-2017) [Compare Source](axios/axios@v0.17.0...v0.17.1) - Fixing issue with web workers ([#​1160](`axios/axios#1160)) - Allowing overriding transport ([#​1080](`axios/axios#1080)) - Updating TypeScript typings ([#​1165](`axios/axios#1165), [#​1125](`axios/axios#1125), [#​1131](`axios/axios#1131)) --- ### [`v0.17.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0170-Oct-21-2017) [Compare Source](axios/axios@v0.16.2...v0.17.0) - **BREAKING** Fixing issue with `baseURL` and interceptors ([#​950](`axios/axios#950)) - **BREAKING** Improving handing of duplicate headers ([#​874](`axios/axios#874)) - Adding support for disabling proxies ([#​691](`axios/axios#691)) - Updating TypeScript typings with generic type parameters ([#​1061](`axios/axios#1061)) --- ### [`v0.16.2`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0162-Jun-3-2017) [Compare Source](axios/axios@v0.16.1...v0.16.2) - Fixing issue with including `buffer` in bundle ([#​887](`axios/axios#887)) - Including underlying request in errors ([#​830](`axios/axios#830)) - Convert `method` to lowercase ([#​930](`axios/axios#930)) --- ### [`v0.16.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0161-Apr-8-2017) [Compare Source](axios/axios@v0.16.0...v0.16.1) - Improving HTTP adapter to return last request in case of redirects ([#​828](`axios/axios#828)) - Updating `follow-redirects` dependency ([#​829](`axios/axios#829)) - Adding support for passing `Buffer` in node ([#​773](`axios/axios#773)) --- ### [`v0.16.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0160-Mar-31-2017) [Compare Source](axios/axios@v0.15.3...v0.16.0) - **BREAKING** Removing `Promise` from axios typings in favor of built-in type declarations ([#​480](`axios/axios#480)) - Adding `options` shortcut method ([#​461](`axios/axios#461)) - Fixing issue with using `responseType: 'json'` in browsers incompatible with XHR Level 2 ([#​654](`axios/axios#654)) - Improving React Native detection ([#​731](`axios/axios#731)) - Fixing `combineURLs` to support empty `relativeURL` ([#​581](`axios/axios#581)) - Removing `PROTECTION_PREFIX` support ([#​561](`axios/axios#561)) --- ### [`v0.15.3`](https://github.com/axios/axios/blob/master/CHANGELOG.md#​0153-Nov-27-2016) [Compare Source](axios/axios@v0.15.2...v0.15.3) - Fixing issue with custom instances and global defaults ([#​443](`axios/axios#443)) - Renaming `axios.d.ts` to `index.d.ts` ([#​519](`axios/axios#519)) - Adding `get`, `head`, and `delete` to `defaults.headers` ([#​509](`axios/axios#509)) - Fixing issue with `btoa` and IE ([#​507](`axios/axios#507)) - Adding support for proxy authentication ([#​483](`axios/axios#483)) - Improving HTTP adapter to use `http` protocol by default ([#​493](`axios/axios#493)) - Fixing proxy issues ([#​491](`axios/axios#491)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
arboehme
added a commit
to arboehme/directus-sdk-javascript
that referenced
this pull request
Aug 16, 2018
…the default upload limit of 10 mb (s. axios/axios#1287).
This was referenced Aug 29, 2019
This was referenced Feb 22, 2020
This was referenced Mar 2, 2020
This was referenced Mar 23, 2020
This was referenced Apr 1, 2020
This was referenced Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
maxBodyLengthon the options sent tofollow-redirectsto match theAxiosOptionspropertymaxContentLength, soaxioscan support content lengths greater than 10mb.Addresses #1286