fix: getAdapter first parameter should accepts 'undefined' type

axios · Dec 2, 2022 · 52f40f5 · 52f40f5
1 parent 66c5789
commit 52f40f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -481,7 +481,7 @@ export interface GenericHTMLFormElement {
   submit(): void;
 }
 
-export function getAdapter(adapters: AxiosAdapterConfig | AxiosAdapterConfig[]): AxiosAdapter;
+export function getAdapter(adapters: AxiosAdapterConfig | AxiosAdapterConfig[] | undefined): AxiosAdapter;
 
 export function toFormData(sourceObj: object, targetFormData?: GenericFormData, options?: FormSerializerOptions): GenericFormData;
 

diff --git a/test/typescript/axios.ts b/test/typescript/axios.ts
@@ -515,6 +515,8 @@ axios.get('/user', {
 
 {
   // getAdapter
+
+  getAdapter(axios.create().defaults.adapter);
   getAdapter([]);
   getAdapter(['xhr']);
   getAdapter([adapter]);
@@ -523,10 +525,11 @@ axios.get('/user', {
   getAdapter([adapter, adapter]);
   getAdapter('xhr');
   getAdapter( adapter);
-  // @ts-expect-error
-  getAdapter('xhr', 'http');
-  // @ts-expect-error
-  getAdapter();
   const _: AxiosAdapter = getAdapter('xhr');
   const __: AxiosAdapter = getAdapter(['xhr']);
+
+  // @ts-expect-error
+  getAdapter();
+  // @ts-expect-error
+  getAdapter('xhr', 'http');
 }