fix json transform when data is pre-stringified

axios · Sep 6, 2021 · 32e9c6d · 32e9c6d
1 parent 4f25380
commit 32e9c6d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/defaults.js b/lib/defaults.js
@@ -58,6 +58,14 @@ var defaults = {
     }
     if (utils.isObject(data) || (headers && headers['Content-Type'] === 'application/json')) {
       setContentTypeIfUnset(headers, 'application/json');
+      if (utils.isString(data)) {
+        try {
+          JSON.parse(data);
+          return data;
+        } catch (e) {
+          return JSON.stringify(data);
+        }
+      }
       return JSON.stringify(data);
     }
     return data;

diff --git a/test/specs/defaults.spec.js b/test/specs/defaults.spec.js
@@ -20,6 +20,18 @@ describe('defaults', function () {
     expect(defaults.transformRequest[0]({foo: 'bar'})).toEqual('{"foo":"bar"}');
   });
 
+  it("should also transform request json when 'Content-Type' is 'application/json'", function () {
+    expect(defaults.transformRequest[0](42, {
+      'Content-Type': 'application/json'
+    })).toEqual('42');
+    expect(defaults.transformRequest[0]('bar', {
+      'Content-Type': 'application/json'
+    })).toEqual('"bar"');
+    expect(defaults.transformRequest[0](JSON.stringify({foo: 'bar'}), {
+      'Content-Type': 'application/json'
+    })).toEqual('{"foo":"bar"}');
+  });
+
   it('should do nothing to request string', function () {
     expect(defaults.transformRequest[0]('foo=bar')).toEqual('foo=bar');
   });