Skip to content

Commit

Permalink
Refactored project file structure to avoid circular imports; (#4220)
Browse files Browse the repository at this point in the history
Co-authored-by: Jay <jasonsaayman@gmail.com>
  • Loading branch information
DigitalBrainJS and jasonsaayman committed Mar 7, 2022
1 parent 6e63edf commit 170588f
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 16 deletions.
4 changes: 2 additions & 2 deletions lib/adapters/http.js
Expand Up @@ -13,7 +13,7 @@ var zlib = require('zlib');
var VERSION = require('./../env/data').version;
var createError = require('../core/createError');
var enhanceError = require('../core/enhanceError');
var defaults = require('../defaults');
var transitionalDefaults = require('../defaults/transitional');
var Cancel = require('../cancel/Cancel');

var isHttps = /https:?/;
Expand Down Expand Up @@ -365,7 +365,7 @@ module.exports = function httpAdapter(config) {
} else {
timeoutErrorMessage = 'timeout of ' + config.timeout + 'ms exceeded';
}
var transitional = config.transitional || defaults.transitional;
var transitional = config.transitional || transitionalDefaults;
reject(createError(
timeoutErrorMessage,
config,
Expand Down
4 changes: 2 additions & 2 deletions lib/adapters/xhr.js
Expand Up @@ -8,7 +8,7 @@ var buildFullPath = require('../core/buildFullPath');
var parseHeaders = require('./../helpers/parseHeaders');
var isURLSameOrigin = require('./../helpers/isURLSameOrigin');
var createError = require('../core/createError');
var defaults = require('../defaults');
var transitionalDefaults = require('../defaults/transitional');
var Cancel = require('../cancel/Cancel');

module.exports = function xhrAdapter(config) {
Expand Down Expand Up @@ -123,7 +123,7 @@ module.exports = function xhrAdapter(config) {
// Handle timeout
request.ontimeout = function handleTimeout() {
var timeoutErrorMessage = config.timeout ? 'timeout of ' + config.timeout + 'ms exceeded' : 'timeout exceeded';
var transitional = config.transitional || defaults.transitional;
var transitional = config.transitional || transitionalDefaults;
if (config.timeoutErrorMessage) {
timeoutErrorMessage = config.timeoutErrorMessage;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/core/transformData.js
@@ -1,7 +1,7 @@
'use strict';

var utils = require('./../utils');
var defaults = require('./../defaults');
var defaults = require('../defaults');

/**
* Transform the data for a request or a response
Expand Down
17 changes: 7 additions & 10 deletions lib/defaults.js → lib/defaults/index.js
@@ -1,8 +1,9 @@
'use strict';

var utils = require('./utils');
var normalizeHeaderName = require('./helpers/normalizeHeaderName');
var enhanceError = require('./core/enhanceError');
var utils = require('../utils');
var normalizeHeaderName = require('../helpers/normalizeHeaderName');
var enhanceError = require('../core/enhanceError');
var transitionalDefaults = require('./transitional');

var DEFAULT_CONTENT_TYPE = {
'Content-Type': 'application/x-www-form-urlencoded'
Expand All @@ -18,10 +19,10 @@ function getDefaultAdapter() {
var adapter;
if (typeof XMLHttpRequest !== 'undefined') {
// For browsers use XHR adapter
adapter = require('./adapters/xhr');
adapter = require('../adapters/xhr');
} else if (typeof process !== 'undefined' && Object.prototype.toString.call(process) === '[object process]') {
// For node use HTTP adapter
adapter = require('./adapters/http');
adapter = require('../adapters/http');
}
return adapter;
}
Expand All @@ -43,11 +44,7 @@ function stringifySafely(rawValue, parser, encoder) {

var defaults = {

transitional: {
silentJSONParsing: true,
forcedJSONParsing: true,
clarifyTimeoutError: false
},
transitional: transitionalDefaults,

adapter: getDefaultAdapter(),

Expand Down
7 changes: 7 additions & 0 deletions lib/defaults/transitional.js
@@ -0,0 +1,7 @@
'use strict';

module.exports = {
silentJSONParsing: true,
forcedJSONParsing: true,
clarifyTimeoutError: false
};
2 changes: 1 addition & 1 deletion test/specs/defaults.spec.js
Expand Up @@ -31,7 +31,7 @@ describe('defaults', function () {
expect(defaults.transformRequest[0](true, headers)).toEqual('true');
expect(defaults.transformRequest[0](false, headers)).toEqual('false');
expect(defaults.transformRequest[0](null, headers)).toEqual('null');
});
});

it('should do nothing to request string', function () {
expect(defaults.transformRequest[0]('foo=bar')).toEqual('foo=bar');
Expand Down

0 comments on commit 170588f

Please sign in to comment.