Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.18 #109

Merged
merged 3 commits into from Mar 21, 2022
Merged

Go 1.18 #109

merged 3 commits into from Mar 21, 2022

Conversation

lukasmalkmus
Copy link
Collaborator

@lukasmalkmus lukasmalkmus commented Mar 16, 2022

This PR introduces Go 1.18 support. Since it isn't used as a package anywhere, this is fine.

We also actively profit from Generics to drop some helper methods that vanished.

Needs golangci/golangci-lint#2438 to pass CI.

@lukasmalkmus lukasmalkmus requested a review from bahlo March 16, 2022 14:21
@lukasmalkmus lukasmalkmus added the enhancement New feature or request label Mar 16, 2022
@lukasmalkmus lukasmalkmus added this to the v0.6.0 milestone Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #109 (65b70cc) into main (26b91ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   14.42%   14.42%           
=======================================
  Files          10       10           
  Lines         520      520           
=======================================
  Hits           75       75           
  Misses        429      429           
  Partials       16       16           
Impacted Files Coverage Δ
pkg/terminal/epipe_other.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b91ef...65b70cc. Read the comment docs.

@lukasmalkmus lukasmalkmus marked this pull request as ready for review March 19, 2022 13:15
@lukasmalkmus lukasmalkmus enabled auto-merge (rebase) March 19, 2022 13:15
@github-actions
Copy link

This PR/issue depends on:

@lukasmalkmus lukasmalkmus merged commit 1859a89 into main Mar 21, 2022
@lukasmalkmus lukasmalkmus deleted the go-1.18 branch March 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants