New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Go 1.18, phase out Go 1.16 #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, I did not know about t.Cleanup(f)
nice! This bump is ok by me, as long as we agree to not introduce any sweeping changes with any
or or type params.
We won't, as So this PR only makes sure we build fine with Go 1.18 (which was expected, tbh) and drops some of the outdated, pre 1.17 build tags.
This has actually been around since Go 1.14. Pretty neat! You might also want to checkout Go 1.17's |
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 71.85% 71.87% +0.02%
==========================================
Files 41 41
Lines 1304 1305 +1
==========================================
+ Hits 937 938 +1
Misses 222 222
Partials 145 145
Continue to review full report at Codecov.
|
This PR/issue depends on:
|
This PR makes sure the package builds fine with the recent Go 1.18. As we just support the lst two minor releases of Go, I'll dropped support for Go 1.16. But as this only affects some toolchain related changes, it will continue to build under Go 1.16 (and possibly lower).
Needs golangci/golangci-lint#2438 to pass CI.