Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.18, phase out Go 1.16 #106

Merged
merged 2 commits into from Mar 19, 2022
Merged

Support Go 1.18, phase out Go 1.16 #106

merged 2 commits into from Mar 19, 2022

Conversation

lukasmalkmus
Copy link
Collaborator

@lukasmalkmus lukasmalkmus commented Mar 16, 2022

This PR makes sure the package builds fine with the recent Go 1.18. As we just support the lst two minor releases of Go, I'll dropped support for Go 1.16. But as this only affects some toolchain related changes, it will continue to build under Go 1.16 (and possibly lower).

Needs golangci/golangci-lint#2438 to pass CI.

@lukasmalkmus lukasmalkmus requested a review from bahlo March 16, 2022 13:47
@lukasmalkmus lukasmalkmus added the enhancement New feature or request label Mar 16, 2022
@lukasmalkmus lukasmalkmus added this to the v0.10.0 milestone Mar 16, 2022
Copy link

@kamstrup kamstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I did not know about t.Cleanup(f) nice! This bump is ok by me, as long as we agree to not introduce any sweeping changes with any or or type params.

@lukasmalkmus
Copy link
Collaborator Author

This bump is ok by me, as long as we agree to not introduce any sweeping changes with any or or type params.

We won't, as axiom-go is supposed to support the last two minor versions of Go, which is now 1.17 and 1.18. In around half a year, when Go 1.19 comes around, we'll go that route and introduce any over interface{} and see if we can use some fancy 1.18 features. This PR is just in draft as we need an upstream fix for golangci-lint.

So this PR only makes sure we build fine with Go 1.18 (which was expected, tbh) and drops some of the outdated, pre 1.17 build tags.

Uh, I did not know about t.Cleanup(f) nice!

This has actually been around since Go 1.14. Pretty neat! You might also want to checkout Go 1.17's T.Setenv method.

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #106 (dcee784) into main (e77ec89) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   71.85%   71.87%   +0.02%     
==========================================
  Files          41       41              
  Lines        1304     1305       +1     
==========================================
+ Hits          937      938       +1     
  Misses        222      222              
  Partials      145      145              
Impacted Files Coverage Δ
axiom/client.go 80.88% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc8339...dcee784. Read the comment docs.

@lukasmalkmus lukasmalkmus marked this pull request as ready for review March 19, 2022 12:52
@github-actions
Copy link

This PR/issue depends on:

@lukasmalkmus lukasmalkmus merged commit 1e4f1c7 into main Mar 19, 2022
@lukasmalkmus lukasmalkmus deleted the go-1.18 branch March 19, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants