consortium-v2: add missing weight field to our customized json marshal #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want json.Marshal to invoke our custom MarshalJSON when be called with non-pointer ValidatorWithBlsPub. In order to do that, we need to define MarshalJSON on a non-pointer receiver.
minh-bq
changed the title
andicrypt
approved these changes
May 16, 2024
minh-bq
added a commit
that referenced
this pull request
May 20, 2024
#449) * consortium-v2: define MarshalJSON on a non-pointer ValidatorWithBlsPub We want json.Marshal to invoke our custom MarshalJSON when be called with non-pointer ValidatorWithBlsPub. In order to do that, we need to define MarshalJSON on a non-pointer receiver. * consortium-v2: add missing weight field to our customized json marshal
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
#449) * consortium-v2: define MarshalJSON on a non-pointer ValidatorWithBlsPub We want json.Marshal to invoke our custom MarshalJSON when be called with non-pointer ValidatorWithBlsPub. In order to do that, we need to define MarshalJSON on a non-pointer receiver. * consortium-v2: add missing weight field to our customized json marshal
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
#449) * consortium-v2: define MarshalJSON on a non-pointer ValidatorWithBlsPub We want json.Marshal to invoke our custom MarshalJSON when be called with non-pointer ValidatorWithBlsPub. In order to do that, we need to define MarshalJSON on a non-pointer receiver. * consortium-v2: add missing weight field to our customized json marshal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want json.Marshal to invoke our custom MarshalJSON when be called with
non-pointer ValidatorWithBlsPub. In order to do that, we need to define
MarshalJSON on a non-pointer receiver.