consortium-v2: support consensus address change in profile contract #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
force-pushed
the
feat/rotating-validator
branch
2 times, most recently
from
765982e
to
178c382
Compare
minh-bq
force-pushed
the
fix/profile-consortium
branch
3 times, most recently
from
1c6dbf0
to
36b3f8e
Compare
This commit adds a step to query profile id from consensus address to support the consensus change feature. It also switches the function call to get BLS public key to another function due to the breaking change in getId2Profile.
Make the contract call a helper function to clean up the code.
minh-bq
force-pushed
the
fix/profile-consortium
branch
from
36b3f8e
to
8650055
Compare
The maxValidatorNumber returns a *big.Int as an output. In order to get the output value, we must pass an **big.Int to the contratCall not *big.Int. Co-authored-by: andicrypt <keepgoing0901@gmail.com>
minh-bq
force-pushed
the
fix/profile-consortium
branch
from
8650055
to
092b5bd
Compare
minh-bq
force-pushed
the
fix/profile-consortium
branch
from
092b5bd
to
786d412
Compare
andicrypt
approved these changes
May 20, 2024
minh-bq
added a commit
that referenced
this pull request
May 20, 2024
…425) * consortium-v2: support consensus address change in profile contract This commit adds a step to query profile id from consensus address to support the consensus change feature. It also switches the function call to get BLS public key to another function due to the breaking change in getId2Profile. * consortium/contract: create contract call helper function Make the contract call a helper function to clean up the code. * consortium-v2: pass **big.Int into contract call's output The maxValidatorNumber returns a *big.Int as an output. In order to get the output value, we must pass an **big.Int to the contratCall not *big.Int. Co-authored-by: andicrypt <keepgoing0901@gmail.com> * consortium-v2: add unit tests for new contract call functions --------- Co-authored-by: andicrypt <keepgoing0901@gmail.com>
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
…425) * consortium-v2: support consensus address change in profile contract This commit adds a step to query profile id from consensus address to support the consensus change feature. It also switches the function call to get BLS public key to another function due to the breaking change in getId2Profile. * consortium/contract: create contract call helper function Make the contract call a helper function to clean up the code. * consortium-v2: pass **big.Int into contract call's output The maxValidatorNumber returns a *big.Int as an output. In order to get the output value, we must pass an **big.Int to the contratCall not *big.Int. Co-authored-by: andicrypt <keepgoing0901@gmail.com> * consortium-v2: add unit tests for new contract call functions --------- Co-authored-by: andicrypt <keepgoing0901@gmail.com>
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
…425) * consortium-v2: support consensus address change in profile contract This commit adds a step to query profile id from consensus address to support the consensus change feature. It also switches the function call to get BLS public key to another function due to the breaking change in getId2Profile. * consortium/contract: create contract call helper function Make the contract call a helper function to clean up the code. * consortium-v2: pass **big.Int into contract call's output The maxValidatorNumber returns a *big.Int as an output. In order to get the output value, we must pass an **big.Int to the contratCall not *big.Int. Co-authored-by: andicrypt <keepgoing0901@gmail.com> * consortium-v2: add unit tests for new contract call functions --------- Co-authored-by: andicrypt <keepgoing0901@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a step to query profile id from consensus address to support the consensus change feature. It also switches the function call to get BLS public key to another function due to the breaking change in getId2Profile.