miner/worker: skip the uncle and resubmit logic in Consortium #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Consortium consensus engine, we don't handle uncle blocks. Furthermore, the uncle logic in worker may block the main creating block logic. So this commit skips the uncle logic when Consortium consensus engine is used.
Currently, after 3 seconds, worker tries to create another block, optimistically thinks that it can get more transactions and earns more fee as a result. However, this causes overhead to the main block creating flow, so skip this logic in Consortium.
minh-bq
force-pushed
the
fix/miner-uncle
branch
from
ddcefc8
to
321774c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Consortium consensus engine, we don't handle uncle blocks. Furthermore, the
uncle logic in worker may block the main creating block logic. So this commit
skips the uncle logic when Consortium consensus engine is used.
Currently, after 3 seconds, worker tries to create another block, optimistically
thinks that it can get more transactions and earns more fee as a result.
However, this causes overhead to the main block creating flow, so skip this
logic in Consortium.