Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue #229

Open
brettz9 opened this issue May 12, 2018 · 3 comments
Open

Security issue #229

brettz9 opened this issue May 12, 2018 · 3 comments

Comments

@brettz9
Copy link

brettz9 commented May 12, 2018

The new npm audit feature, which alerts one to security warnings on dependencies, indicates a high risk denial of service issue with the dependency on saucelabs which had a bad version of https-proxy-agent as a dependency.

Also, the dependency on lodash before 4.17.5 was subject to prototype pollution, and grunt-saucelabs is relying upon this version in two ways:

  1. by relying on lodash as a direct dependency using the tilde (only accepting patch updates) above 4.13.1) .
  2. by relying on requestretry (which relies on fg-lodash which relies on lodash) using the tilde (only accepting patch updates) above 1.9.0).

Upgrading to the latest versions should fix all of these issues. (There are a number of security issues when doing an audit against a local install of grunt-saucelabs, but the above are the only ones I'm seeing as a dependency.)

While I could submit a PR to upgrade these, I am getting errors when trying to run npm test, so I'm not sure whether upgrades would break anything.

I know you're not actively maintaining, @axemclion , but could you look into this both as it is security -related, and because I'm trying to get rid of the issues for the sake of IndexedDBShim as well?

@gcbw
Copy link

gcbw commented Oct 3, 2018

#230

@brettz9
Copy link
Author

brettz9 commented Oct 11, 2018

@axemclion , If you are too busy to maintain, would you mind granting me access to this repo so I could at least merge this security fix or such?

@digitalfrost
Copy link
Contributor

Pull request: to update saucelabs and lodash versions to fix security vulnerabilities #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants