Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit 'vulnerabilities' #738

Closed
ghost opened this issue Jul 18, 2018 · 2 comments
Closed

npm audit 'vulnerabilities' #738

ghost opened this issue Jul 18, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 18, 2018

I looked into the results of npm audit (which is now run automatically on an npm install?), and I wanted to share my thoughts on that.

The reported "high" vulnerabilities come from versions of sshpk and https-proxy-agent, which in the end are themselves dependencies of grunt-saucelabs. I did not find a way of updating both of these two packages that satisfies npm. Repairing/updating one of them leads to the other being broken.

Removing grunt-saucelabs leads to a clean npm audit. So my conclusion is that these "vulnerabilities" (Denial of service) only affect grunt-saucelabs, which seems to be some non-critical testing.

TL;DR: These are ugly, but not currently a problem?

@twiss
Copy link
Member

twiss commented Jul 23, 2018

Open issue in grunt-saucelabs: axemclion/grunt-saucelabs#229. Apparently it's not currently actively maintained. But yeah, this shouldn't cause any actual security issues in OpenPGP.js itself.

@chesnokovilya
Copy link
Contributor

closed by #965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants