Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes logging for Parameter Store and Secrets Manager integrations #229

Merged
merged 4 commits into from Feb 9, 2022

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Feb 6, 2022

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Fixes logging for Parameter Store and Secrets Manager integrations when used with spring.config.import. Implemented in similar way it's been done to Spring Vault integration spring-cloud/spring-cloud-vault#565

Fixes #194
Fixes #165

... when used with `spring.config.import`.

Fixes #194
... when used with `spring.config.import`.

Fixes #194
@maciejwalkowiak maciejwalkowiak added this to the 2.3.4 milestone Feb 6, 2022
@github-actions github-actions bot added component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue labels Feb 6, 2022
@maciejwalkowiak maciejwalkowiak added the type: enhancement Smaller enhancement in existing integration label Feb 8, 2022
Copy link
Member

@MatejNedic MatejNedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few questions about samples

@maciejwalkowiak maciejwalkowiak merged commit 3cb6589 into 2.3.x Feb 9, 2022
@maciejwalkowiak maciejwalkowiak deleted the gh-194 branch February 9, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: parameter-store Parameter Store integration related issue component: secrets-manager Secrets Manager integration related issue type: enhancement Smaller enhancement in existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging for Parameter Store Spring Boot logging and missing traces
2 participants