Fix kms #68
Merged
Fix kms #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_config and aws_sdk_kms no longer matched, causing for this feature to not compile. This patch bring the aws_sdk_kms to latest version, which works with the latest aws_config. Signed-off-by: Petre Eftime <petre.eftime@gmail.com>
Unfortunately tests require AWS creds, so skip running the tests, but at least make sure that the feature still compiles correctly. Signed-off-by: Petre Eftime <petre.eftime@gmail.com>
AWS SDK and time crate no longer compile with 1.58 and need minimum 1.67. Signed-off-by: Petre Eftime <petre.eftime@gmail.com>
Fix warnings about deprecated node versions for checkout v2. Signed-off-by: Petre Eftime <petre.eftime@gmail.com>
belveryin
approved these changes
Oct 3, 2023
belveryin
suggested changes
Oct 3, 2023
|
Fixed, and also included a fix for the warnings regarding node12 deprecation for actions/checkout@v2. |
belveryin
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.